-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update plus plugins version #4619
Conversation
8b8ebb7
to
57e0824
Compare
a117208
to
84185d2
Compare
84185d2
to
d6714d0
Compare
.github/workflows/actions.yaml
Outdated
@@ -114,10 +114,10 @@ jobs: | |||
- name: Git Checkout | |||
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # 3.5.3 | |||
|
|||
- uses: actions/setup-java@cd89f46ac9d01407894225f350157564c9c7cee2 # 3.12.0 | |||
- uses: actions/setup-java@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Is there a reason we are changing this from a sha to a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to use the same commit sha as before
final isConnected = connectivityResults | ||
.any((result) => result != ConnectivityResult.none); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: What should the behavior be if the result contains ConnectivityResult.none AND ConnectivityResult.wifi? Is that possible?
nit: I think you can simplify this:
final isConnected = connectivityResults.contains(ConnectivityResult.none);
This is out of scope for this PR, but it seems like ConnectivityResult.bluetooth would be treated like an active connection. Same with ConnectivityResult.other. I am not sure if we want to treat those like an active connection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on their doc it is not possible to have ConnectivityResult.none AND ConnectivityResult.wifi.
In case of no connectivity, the list contains a single element of [ConnectivityResult.none]. Note also that this is the only case where [ConnectivityResult.none] is present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean
final isNotConnected = connectivityResults.contains(ConnectivityResult.none);
I think this may be less efficent as it checks all the elements in the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is what I meant.
.contains()
will exit at the first element that matches.
Here is the implementation.
bool contains(Object? element) {
for (E e in this) {
if (e == element) return true;
}
return false;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, this is the case where the list contains ConnectivityResult.none (it happens when the device is not conntected and the list supposed to only have one element and it is ConnectivityResult.none). I meant the senarios when the device is connected and so the list may have multiple elements and none of them is ConnectivityResult.none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Makes sense.
* update dart and flutter sdk version * run dart fix * update _plus plugin versions and fix the code for breaking changes
### Features - feat: deprecate `Storage.move()` API ([#4638](#4638)) - feat: update `built_value` version constraint ([#4634](#4634)) - feat: update plus plugins version ([#4619](#4619)) ### Fixes - fix(api): Paginated GraphQL preserve request params ([#4605](#4605)) - fix(api): Web socket decode connection errors ([#4606](#4606)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
### Features - feat: deprecate `Storage.move()` API ([#4638](#4638)) - feat: update `built_value` version constraint ([#4634](#4634)) - feat: update plus plugins version ([#4619](#4619)) ### Fixes - fix(api): Paginated GraphQL preserve request params ([#4605](#4605)) - fix(api): Web socket decode connection errors ([#4606](#4606)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
### Features - feat: deprecate `Storage.move()` API ([#4638](#4638)) - feat: update `built_value` version constraint ([#4634](#4634)) - feat: update plus plugins version ([#4619](#4619)) ### Fixes - fix(api): Paginated GraphQL preserve request params ([#4605](#4605)) - fix(api): Web socket decode connection errors ([#4606](#4606)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
### Features - feat: deprecate `Storage.move()` API ([#4638](#4638)) - feat: update `built_value` version constraint ([#4634](#4634)) - feat: update plus plugins version ([#4619](#4619)) ### Fixes - fix(api): Paginated GraphQL preserve request params ([#4605](#4605)) - fix(api): Web socket decode connection errors ([#4606](#4606)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
* update dart and flutter sdk version * run dart fix * update _plus plugin versions and fix the code for breaking changes
### Features - feat: deprecate `Storage.move()` API ([#4638](#4638)) - feat: update `built_value` version constraint ([#4634](#4634)) - feat: update plus plugins version ([#4619](#4619)) ### Fixes - fix(api): Paginated GraphQL preserve request params ([#4605](#4605)) - fix(api): Web socket decode connection errors ([#4606](#4606)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
### Features - feat: deprecate `Storage.move()` API ([#4638](#4638)) - feat: update `built_value` version constraint ([#4634](#4634)) - feat: update plus plugins version ([#4619](#4619)) ### Fixes - fix(api): Paginated GraphQL preserve request params ([#4605](#4605)) - fix(api): Web socket decode connection errors ([#4606](#4606)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
### Features - feat: deprecate `Storage.move()` API ([#4638](#4638)) - feat: update `built_value` version constraint ([#4634](#4634)) - feat: update plus plugins version ([#4619](#4619)) ### Fixes - fix(api): Paginated GraphQL preserve request params ([#4605](#4605)) - fix(api): Web socket decode connection errors ([#4606](#4606)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
is it an expected behavior? |
Issue #, if available: #4601
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.