Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): update the sdk yaml definition for cloudwatch logs and regenerate the sdks #4367

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented Jan 18, 2024

Issue #, if available:

Description of changes:

  • the cloudwatch logs' sdk.yaml file was based on the old aft generate command that uses the private repo and so we could not regenerate the cloudwatch logs sdks.
  • update the sdk.yaml file to use the new format based on the public repo and ran aft generate sdk to regenerate the sdk files
  • add logging category to log cw metrics git hub actions to fix ci builds

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner January 18, 2024 23:37
@NikaHsn NikaHsn force-pushed the chore/logging/fix-generate-sdk branch 2 times, most recently from e3c5265 to aad94a6 Compare January 23, 2024 16:33
@NikaHsn NikaHsn force-pushed the chore/logging/fix-generate-sdk branch from aad94a6 to 9cb02b5 Compare January 23, 2024 16:54
Copy link
Contributor

@Equartey Equartey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikaHsn NikaHsn merged commit 5ea7b0e into feat/logging/cloudwatch Jan 25, 2024
29 checks passed
@NikaHsn NikaHsn deleted the chore/logging/fix-generate-sdk branch January 31, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants