feat(logging): cloudwatch logging plugin to implement logging plugin interface #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| void _disableLogging() { | ||
| _plugin.disable(); | ||
| Amplify.Logging.enable(); |
There was a problem hiding this comment.
is this supposed to be Amplify.Logging.enable() for the _disableLogging() call?
Equartey
reviewed
Nov 14, 2023
Comment on lines
-27
to
-32
| - 'packages/smithy/smithy/lib/**/*.dart' | ||
| - 'packages/smithy/smithy/pubspec.yaml' | ||
| - 'packages/smithy/smithy_aws/lib/**/*.dart' | ||
| - 'packages/smithy/smithy_aws/pubspec.yaml' |
There was a problem hiding this comment.
Are the smithy changes related?
There was a problem hiding this comment.
yes they are. they were added because of adding aws_logging_cloudwatch.
Equartey
approved these changes
Nov 14, 2023
NikaHsn
force-pushed
the
feat/logging/cloudwatch
branch
from
11d0d04 to
1fbc85e
Compare
khatruong2009
approved these changes
Nov 14, 2023
NikaHsn
merged commit 93a2f8e
into
aws-amplify:feat/logging/cloudwatch
384 of 486 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.