Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(smithy): casts output to fix beta tests #3963

Merged
merged 3 commits into from
Oct 18, 2023
Merged

fix(smithy): casts output to fix beta tests #3963

merged 3 commits into from
Oct 18, 2023

Conversation

haverchuck
Copy link
Contributor

Description of changes:
Casts output to fix the following beta test failure:

Failed to build aft:aft:
packages/smithy/smithy/lib/src/http/http_operation.dart:271:16: Error: A value of type 'Object?' can't be assigned to a variable of type 'Output?'.
 - 'Object' is from 'dart:core'.
      output = switch (payload) {
               ^

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haverchuck haverchuck force-pushed the fix/smithy/beta-tests branch from b6556a8 to fd9a460 Compare October 17, 2023 17:42
@haverchuck haverchuck marked this pull request as ready for review October 17, 2023 22:42
@haverchuck haverchuck requested a review from a team as a code owner October 17, 2023 22:42
@haverchuck haverchuck force-pushed the fix/smithy/beta-tests branch from 6ca670c to c991bbc Compare October 18, 2023 14:46
@haverchuck haverchuck merged commit 6ab1a67 into main Oct 18, 2023
285 of 289 checks passed
@Jordan-Nelson Jordan-Nelson mentioned this pull request Oct 20, 2023
Closed
14 tasks
@Jordan-Nelson Jordan-Nelson deleted the fix/smithy/beta-tests branch October 20, 2023 18:47
Equartey pushed a commit that referenced this pull request Oct 26, 2023
@haverchuck @Equartey
fix(smithy): defines Output type to fix beta tests (#3963)
91ab21f
Equartey added a commit that referenced this pull request Oct 26, 2023
@Equartey
chore(version): Bump version
390a562 
### Features
- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

### Fixes
- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

### Breaking Changes
- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@Equartey Equartey mentioned this pull request Oct 26, 2023
Merged
Equartey added a commit that referenced this pull request Oct 26, 2023
@Equartey
chore(version): Bump version
d3fbeee 
### Features
- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

### Fixes
- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

### Breaking Changes
- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey pushed a commit that referenced this pull request Oct 30, 2023
@haverchuck @Equartey
fix(smithy): defines Output type to fix beta tests (#3963)
982c93d
Equartey added a commit that referenced this pull request Oct 30, 2023
@Equartey
chore(version): Bump version
dcc7d22 
### Features
- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

### Fixes
- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

### Breaking Changes
- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey added a commit that referenced this pull request Oct 30, 2023
@Equartey
chore(version): Bump version
02499dc 
- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey added a commit that referenced this pull request Nov 6, 2023
@Equartey
Cherry pick stable to main 1.6.0 (#4031)
135d7d0 
* chore(version): Bump version

- feat: rename sendUserAttributeVerificationCode ([#3759](#3759))

- fix(aft): Small fixes ([#3838](#3838))
- fix(analytics): allow nullable userProfile
- fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999))
- fix(auth): use loadCredentials to check login state
- fix(authenticator): Beta channel fixes ([#3835](#3835))
- fix(authenticator): fix validate before trim bug ([#3809](#3809))
- fix(authenticator): use getCurrentUser to check sign in state
- fix(pub): ignore templates folder during analysis ([#4009](#4009))
- fix(smithy): defines Output type to fix beta tests ([#3963](#3963))
- fix: catch and log updateEndpoint error during configure ([#3985](#3985))
- fix: remove exception during token timeout ([#3939](#3939))

- fix(smithy_aws)!: do not sign optional requests

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee

* fix: slide smithy_codegen window

* fix: added drop dep
khatruong2009 pushed a commit that referenced this pull request Nov 7, 2023
@haverchuck @khatruong2009
fix(smithy): defines Output type to fix beta tests (#3963)
c7a37ee
@Jordan-Nelson Jordan-Nelson mentioned this pull request Jan 25, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jordan-Nelson Jordan-Nelson Jordan-Nelson approved these changes

@NikaHsn NikaHsn NikaHsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haverchuck @NikaHsn @Jordan-Nelson