Feat/mine/finalized dart action v3 #3874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 25, 2023 16:32
Logs metrics to CW Takes in various parameters (we agreed upon) for differentiating metrics Automatically gets the failing step of a test to report
|
Please ignore:
Desired review:
|
dnys1
reviewed
Sep 29, 2023
| test-type: unit | ||
| working-directory: ${{ inputs.working-directory }} | ||
|
|
||
| framework: flutter |
There was a problem hiding this comment.
The other way to do this instead of passing this in for each workflow is just keep a map in the action of workflowName -> values.
fjnoyp
force-pushed
the
feat/mine/finalizedDartActionV3
branch
from
4fbeea4 to
daa02d3
Compare
fjnoyp
force-pushed
the
feat/mine/finalizedDartAction
branch
from
6197c29 to
617bf67
Compare
fjnoyp
force-pushed
the
feat/mine/finalizedDartActionV3
branch
2 times, most recently
from
7453bb8 to
68c971c
Compare
chore(repo): update base github workflows to log TEMP: Force sample tests to check behavior debug tests update log metric TEMP - FORCE NON SCHEDULED TESTS fix nullable job conclusions issue Attempt to fix errors fix null matrix sends test casing fix for finding failing job update job identifier to include workflow name TEMP REMOVE - use normal runners Update tests to fix duplicate name issues FORCE another TEST
fjnoyp
force-pushed
the
feat/mine/finalizedDartActionV3
branch
from
aa5498c to
96281ff
Compare
added 3 commits
October 6, 2023 09:47
fjnoyp
force-pushed
the
feat/mine/finalizedDartAction
branch
from
2e75b63 to
3cec5b1
Compare
fjnoyp
force-pushed
the
feat/mine/finalizedDartActionV3
branch
from
f37f8e6 to
aa7876e
Compare
fjnoyp
force-pushed
the
feat/mine/finalizedDartAction
branch
from
3cec5b1 to
8e93481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add logic to send Cloudwatch metrics from all Github Action workflows.
Update aft to generate workflows that track metrics.
Update base github workflows to track metrics.
WIP:
Null matrix causes log metric to crash.
Null value error unknown cause
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.