Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aft): removed 'has-goldens' check from dart_vm.yaml workflows #3807

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix(aft): removed 'has-goldens' check from dart_vm.yaml workflows #3807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/amplify_analytics_pinpoint_dart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ jobs:
with:
package-name: amplify_analytics_pinpoint_dart
working-directory: packages/analytics/amplify_analytics_pinpoint_dart
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/amplify_api_dart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ jobs:
with:
package-name: amplify_api_dart
working-directory: packages/api/amplify_api_dart
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/amplify_auth_cognito_dart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ jobs:
with:
package-name: amplify_auth_cognito_dart
working-directory: packages/auth/amplify_auth_cognito_dart
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/amplify_auth_cognito_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ jobs:
with:
package-name: amplify_auth_cognito_test
working-directory: packages/auth/amplify_auth_cognito_test
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/amplify_core.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ jobs:
with:
package-name: amplify_core
working-directory: packages/amplify_core
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/amplify_db_common_dart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ jobs:
with:
package-name: amplify_db_common_dart
working-directory: packages/common/amplify_db_common_dart
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/amplify_lints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,3 @@ jobs:
with:
package-name: amplify_lints
working-directory: packages/amplify_lints
has-goldens: false
1 change: 0 additions & 1 deletion .github/workflows/amplify_secure_storage_dart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,3 @@ jobs:
with:
package-name: amplify_secure_storage_dart
working-directory: packages/secure_storage/amplify_secure_storage_dart
has-goldens: false
1 change: 0 additions & 1 deletion .github/workflows/amplify_secure_storage_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: amplify_secure_storage_test
working-directory: packages/secure_storage/amplify_secure_storage_test
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/amplify_storage_s3_dart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ jobs:
with:
package-name: amplify_storage_s3_dart
working-directory: packages/storage/amplify_storage_s3_dart
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/aws_common.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ jobs:
with:
package-name: aws_common
working-directory: packages/aws_common
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/aws_json1_0_v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: aws_json1_0_v1
working-directory: packages/smithy/goldens/lib/awsJson1_0
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/aws_json1_0_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: aws_json1_0_v2
working-directory: packages/smithy/goldens/lib2/awsJson1_0
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/aws_json1_1_v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: aws_json1_1_v1
working-directory: packages/smithy/goldens/lib/awsJson1_1
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/aws_json1_1_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: aws_json1_1_v2
working-directory: packages/smithy/goldens/lib2/awsJson1_1
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/aws_query_v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: aws_query_v1
working-directory: packages/smithy/goldens/lib/awsQuery
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/aws_query_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: aws_query_v2
working-directory: packages/smithy/goldens/lib2/awsQuery
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/aws_signature_v4.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ jobs:
with:
package-name: aws_signature_v4
working-directory: packages/aws_signature_v4
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/cognito_example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,3 @@ jobs:
with:
package-name: cognito_example
working-directory: packages/auth/amplify_auth_cognito_dart/example
has-goldens: false
1 change: 0 additions & 1 deletion .github/workflows/custom_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: custom_v2
working-directory: packages/smithy/goldens/lib2/custom
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ec2_query_v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: ec2_query_v1
working-directory: packages/smithy/goldens/lib/ec2Query
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ec2_query_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: ec2_query_v2
working-directory: packages/smithy/goldens/lib2/ec2Query
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/pub_server.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ jobs:
with:
package-name: pub_server
working-directory: packages/test/pub_server
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/rest_json1_v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: rest_json1_v1
working-directory: packages/smithy/goldens/lib/restJson1
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/rest_json1_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: rest_json1_v2
working-directory: packages/smithy/goldens/lib2/restJson1
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/rest_xml_v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: rest_xml_v1
working-directory: packages/smithy/goldens/lib/restXml
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/rest_xml_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: rest_xml_v2
working-directory: packages/smithy/goldens/lib2/restXml
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/rest_xml_with_namespace_v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: rest_xml_with_namespace_v1
working-directory: packages/smithy/goldens/lib/restXmlWithNamespace
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/rest_xml_with_namespace_v2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
with:
package-name: rest_xml_with_namespace_v2
working-directory: packages/smithy/goldens/lib2/restXmlWithNamespace
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/smithy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ jobs:
with:
package-name: smithy
working-directory: packages/smithy/smithy
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/smithy_aws.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ jobs:
with:
package-name: smithy_aws
working-directory: packages/smithy/smithy_aws
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/smithy_codegen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ jobs:
with:
package-name: smithy_codegen
working-directory: packages/smithy/smithy_codegen
has-goldens: false
native_test:
needs: test
uses: ./.github/workflows/dart_native.yaml
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/storage_s3_example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,3 @@ jobs:
with:
package-name: storage_s3_example
working-directory: packages/storage/amplify_storage_s3_dart/example
has-goldens: false
1 change: 0 additions & 1 deletion .github/workflows/worker_bee.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,3 @@ jobs:
with:
package-name: worker_bee
working-directory: packages/worker_bee/worker_bee
has-goldens: false
1 change: 0 additions & 1 deletion .github/workflows/worker_bee_builder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,3 @@ jobs:
with:
package-name: worker_bee_builder
working-directory: packages/worker_bee/worker_bee_builder
has-goldens: false
8 changes: 7 additions & 1 deletion packages/aft/lib/src/commands/generate/generate_workflows_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,15 @@ jobs:
with:
package-name: ${package.name}
working-directory: $repoRelativePath
has-goldens: $hasGoldens
''',
);
if (!isDartPackage) {
workflowContents.write(
'''
has-goldens: $hasGoldens
''',
);
}

if (needsNativeTest) {
workflowContents.write(
Expand Down
Loading