chore(aft): Use public models #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
force-pushed
the
chore/aft/use-public-models
branch
4 times, most recently
from
d4b7942 to
e9513c9
Compare
added 2 commits
September 12, 2023 13:38
Migrates the `generate sdk` command to use the public `aws-sdk-js-v3` repo for service models instead of the private repo.
Clean up for nullability checks and deserialization logic
dnys1
force-pushed
the
chore/aft/use-public-models
branch
from
e9513c9 to
258667e
Compare
dnys1
force-pushed
the
chore/aft/use-public-models
branch
from
258667e to
34d1b40
Compare
Jordan-Nelson
approved these changes
Sep 13, 2023
Equartey
approved these changes
Sep 13, 2023
| .singleWhere( | ||
| (service) => | ||
| service.expectTrait<ServiceTrait>().endpointPrefix == apiName, | ||
| .singleWhere((service) => service.shapeId.namespace == namespace); |
There was a problem hiding this comment.
Cool function, didn't know this existed.
Comment on lines
+194
to
+201
| for (final operation in includeOperations) { | ||
| if (!allOperations.contains(operation)) { | ||
| throw Exception( | ||
| 'Invalid operation specified for $namespace: $operation', | ||
| ); | ||
| includeShapes.addAll(serviceShape.operations.map((op) => op.target)); | ||
| } | ||
| } | ||
| includeShapes.addAll(includeOperations); |
There was a problem hiding this comment.
Could flatten this logic a little bit.
final isMissingOp = includeOperations.every((e) => !allOperations.contains(operation));
if (isMissingOp) {
throw Exception(
'Invalid operation specified for $namespace: $operation',
);
}
includeShapes.addAll(includeOperations);There was a problem hiding this comment.
Yeah, started with something like that. This turned out to be cleaner - the problem is getting the element which didn't pass the condition, i.e. operation in your snippet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the
generate sdkcommand to use the publicaws-sdk-js-v3repo for service models instead of the private repo.Fixes some minor codegen issues and regenerates SDK (thus the large PR)