chore(repo): Clean up workers #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
force-pushed
the
chore/auth/avoid-worker-null-checks
branch
from
06d3566 to
c11f423
Compare
dnys1
force-pushed
the
chore/auth/avoid-worker-null-checks
branch
2 times, most recently
from
3340bbb to
6a907ff
Compare
Equartey
previously approved these changes
Sep 5, 2023
added 3 commits
September 5, 2023 09:46
Force unwrapping nullable values is done in JS by calling `nullableValue.toString` which will throw an error if `nullableValue` is null. Browsers seem to handle this sort of error different than a thrown Dart error and the error is harder to trace when it happens. Introduces an `unwrapParameter` method to the base worker bee class so that unwrap errors are strongly-typed and provide more context to the issue.
Running heavy computations on the main thread in Web tests causes flaky behavior. Even on high performance computers, the interplay of the Dart runner, DDC, and browser engine causes frequent timeouts when blocking the main thread. Since these operations are tested elsewhere for Web in places where they are offloaded, skip them for Web.
dnys1
force-pushed
the
chore/auth/avoid-worker-null-checks
branch
from
6a907ff to
c0dbaa4
Compare
Equartey
approved these changes
Sep 5, 2023
Jordan-Nelson
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force unwrapping nullable values (
!) is done in JS by callingnullableValue.toStringwhich will throw an error ifnullableValueis null. Browsers seem to handle this sort of error different than a thrown Dart error and the error is harder to trace when it happens.Introduces an
unwrapParametermethod to the base worker bee class so that unwrap errors are strongly-typed and provide more context to the issue.Adds some other cleanup to improve performance, and enables lints in the
amplify_secure_storage_testpackage.