import named export from parcel/watcher #2332
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
in a limited env like WebContainers we're seeing issues related to the import of the "default" export from the commonjs distribution of parcel/watcher. "default" exports are a concept in ESM, where commonjs will export on
module.exports
orexports
. Depending on the build process these are sometimes rebound to a nameddefault
->module.exports.default = "something"
or merged ontomodule.exports
Issue number, if available:
Changes
This change removes the import of parcel/watchers default export in favor of the named
subscribe
export.subscribe
was already in use for typing, so this change is smallCorresponding docs PR, if applicable:
Validation
validated by re-running the sandbox command in the limited WebContainers env
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.