chore: Fix building in Android Studio Ladybug #2961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Android Studio Ladybug ships with an embedded JVM of 21.0.3. Since we were not being explicit in which JVM to use for compilation, this caused builds to fail because our Java code was being compiled with Java 21, while our Kotlin verison only supports up to Java 20.
I resolved this by explicitly setting the
jvmToolchain
to 17 for all gradle builds, regardless of whether it's from command line, on CI, or in the IDE.I also had to disable the
-Werror
compiler option. It appears that this option was previously being disregarded, which has allowed many warnings to accumulate. Once these warnings are addressed then we can re-enable-Werror
to prevent additional warnings from being introduced.How did you test these changes?
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.