Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix building in Android Studio Ladybug #2961

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Android Studio Ladybug ships with an embedded JVM of 21.0.3. Since we were not being explicit in which JVM to use for compilation, this caused builds to fail because our Java code was being compiled with Java 21, while our Kotlin verison only supports up to Java 20.

I resolved this by explicitly setting the jvmToolchain to 17 for all gradle builds, regardless of whether it's from command line, on CI, or in the IDE.

I also had to disable the -Werror compiler option. It appears that this option was previously being disregarded, which has allowed many warnings to accumulate. Once these warnings are addressed then we can re-enable -Werror to prevent additional warnings from being introduced.

How did you test these changes?

  • Verified that project now builds in Ladybug.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner December 2, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants