Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix storage list with multiple buckets #2908

Merged

Conversation

phantumcode
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Fix issue with the Storage list api always defaulting to the default storage service instead of using the storage service based on whether a different bucket is passed in as part of the options parameter.

How did you test these changes?
Failed integration tests now passes.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@phantumcode phantumcode requested a review from a team as a code owner September 4, 2024 21:25
@phantumcode phantumcode merged commit 2cbe597 into feature/storage_multi-bucket_support Sep 5, 2024
@phantumcode phantumcode deleted the chore/fix_storage_list branch September 5, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants