-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): update multipart operations to support multiple buckets/regions #2899
Merged
phantumcode
merged 17 commits into
feature/storage_multi-bucket_support
from
phantum/storage-update-transfer-db
Aug 27, 2024
Merged
feat(storage): update multipart operations to support multiple buckets/regions #2899
phantumcode
merged 17 commits into
feature/storage_multi-bucket_support
from
phantum/storage-update-transfer-db
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lawmicha
approved these changes
Aug 22, 2024
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/AWSS3StoragePlugin.java
Outdated
Show resolved
Hide resolved
Base automatically changed from
phantum/storage_options_bucket
to
feature/storage_multi-bucket_support
August 22, 2024 15:22
tylerjroach
reviewed
Aug 22, 2024
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/transfer/TransferTable.kt
Show resolved
Hide resolved
...e-s3/src/main/java/com/amplifyframework/storage/s3/transfer/StorageTransferClientProvider.kt
Outdated
Show resolved
Hide resolved
...s3/src/main/java/com/amplifyframework/storage/s3/transfer/S3StorageTransferClientProvider.kt
Show resolved
Hide resolved
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/service/AWSS3StorageService.kt
Outdated
Show resolved
Hide resolved
tylerjroach
approved these changes
Aug 27, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-bucket support part 3
This the third part of a series of changes/pull request to support multi-bucket in the S3 Storage Plugin. The series of changes will be reviewed and merged into a feature branch and combined into a single pull request to be reviewed and merged into main branch.
part 1: #2895
part 2: #2896
Issue #, if available:
Description of changes:
AWSS3Service
based on bucket name and regionIntegration tests will be added in a separate followup PR (#2900)
How did you test these changes?
Documentation update required?
General Checklist
Added Integration TestsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.