Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use android studio code style #2890

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Newer versions of the KtLint IDE plugin respond to the ktlint_code_style setting in .editorconfig. Adding this rule prevents the plugin from trying to make invalid formatting changes.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner August 8, 2024 16:17
@mattcreaser
Copy link
Member Author

Note: we also need to update the gradle ktlint plugin to align the rulesets, but that change impacts ~175 files so I only addressed the IDE plugin in this PR.

@mattcreaser mattcreaser enabled auto-merge (squash) August 9, 2024 13:09
@mattcreaser mattcreaser merged commit cfe0de0 into main Aug 9, 2024
4 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/ktlint-code-style branch August 9, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants