-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(predictions): Add support for a no light freshness challenge #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phantumcode
reviewed
Jun 5, 2024
core/src/main/java/com/amplifyframework/predictions/models/FaceLivenessSessionInformation.kt
Outdated
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
core/src/main/java/com/amplifyframework/predictions/models/FaceLivenessSessionInformation.kt
Outdated
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
core/src/main/java/com/amplifyframework/predictions/models/FaceLivenessSession.kt
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
...ictions/src/main/java/com/amplifyframework/predictions/aws/service/RunFaceLivenessSession.kt
Outdated
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
...ictions/src/main/java/com/amplifyframework/predictions/aws/service/RunFaceLivenessSession.kt
Outdated
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
core/src/main/java/com/amplifyframework/predictions/models/FaceLivenessChallengeType.kt
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
...ictions/src/main/java/com/amplifyframework/predictions/aws/models/liveness/ChallengeEvent.kt
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests on the new UrlBuilder being used on the websocket?
vincetran
force-pushed
the
liveness-no-light-sku-support
branch
from
June 19, 2024 21:44
11f2e23
to
13e4a1b
Compare
tylerjroach
reviewed
Jun 21, 2024
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplifyframework/predictions/models/FaceLivenessSessionInformation.kt
Outdated
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
vincetran
force-pushed
the
liveness-no-light-sku-support
branch
from
June 26, 2024 20:06
fae9a82
to
b51112b
Compare
tylerjroach
reviewed
Jun 28, 2024
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 28, 2024
...ictions/src/main/java/com/amplifyframework/predictions/aws/service/RunFaceLivenessSession.kt
Outdated
Show resolved
Hide resolved
tylerjroach
reviewed
Jun 28, 2024
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Show resolved
Hide resolved
…ted challenge type is found
vincetran
force-pushed
the
liveness-no-light-sku-support
branch
from
July 2, 2024 14:05
14f2487
to
ea3d768
Compare
tylerjroach
approved these changes
Jul 2, 2024
phantumcode
approved these changes
Jul 2, 2024
vincetran
added a commit
that referenced
this pull request
Jul 30, 2024
vincetran
added a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
This adds support for a no-light challenge to the Prediction plugin's Face LIveness feature and adds telemetry tracking as requested by the Rekognition team. There's no API change to the core plugin API and additive changes to the
FaceLivenessSessionInformation
data class that's used as part of the API.Notable callouts:
FaceLivenessSessionInformation
String
challenge
parameter to be nullable. This is required to allow backward compatibility with the existing Liveness UI component library.challengeVersions
to replace the previouschallenge
which takes in aList<Challenge>
. TheseChallenge
s represent both the challenge name and the version for that challenge.preCheckViewEnabled
which signifies if the default "Start View" was enabled. Used for telemetry.attemptCount
which signifies how many times the user attempted to perform the liveness check. Used for telemetry.FaceMovementChallenge
that will live alongside the existing supportedFaceMovementAndLightChallenge
Uri.Builder()
for code cleanlinessChallengeType
which is used for determining what type of challenge is requested from the backend to render to the user.How did you test these changes?
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.