fix(api): Don't prevent subscribing with API_KEY when there is also an owner-based rule #2828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2770
Description of changes:
This fix applies to models that have multiple types of authentication, e.g:
This schema translates into a model that has the following auth rules:
We would previously disallow subscribing to this model using
AuthorizationType.API_KEY
, because of the presence of theAuthStrategy.OWNER
rule. You should be able to subscribe using either type. If usingAuthorizationType.API_KEY
then you receive events for all models, while if usingAuthorizationType.COGNITO_USER_POOLS
you receive events only for your own models.I also fixed a bug I noticed that could (rarely) prevent proper shutting down of the subscription when using MultiAuth subscriptions.
How did you test these changes?
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.