Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add comment author to slack webhook payload #2812

Merged
merged 1 commit into from
May 9, 2024
Merged

chore: Add comment author to slack webhook payload #2812

merged 1 commit into from
May 9, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
This will allow surfacing the comment author to Amplify channels

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner May 9, 2024 14:31
@mattcreaser mattcreaser merged commit efb2b11 into main May 9, 2024
4 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/comment-user branch May 9, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhengshs yuhengshs yuhengshs approved these changes

@joon-won joon-won joon-won approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattcreaser @joon-won @yuhengshs