Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add APIs to lazily evaluate log statements #2811

Merged
merged 7 commits into from
May 15, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2730

Description of changes:
While evaluated observeQuery performance we noted that we were spending quite a lot of time constructing strings for verbose log messages. This PR adds an API to lazily perform potentially expensive log message construction, which can make a significant impact for some log statements.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners May 9, 2024 13:54
tylerjroach
tylerjroach previously approved these changes May 9, 2024
@mattcreaser mattcreaser changed the title feat(core): Add APIs to lazily-evaluate log statements feat(core): Add APIs to lazily evaluate log statements May 9, 2024
@mattcreaser mattcreaser enabled auto-merge (squash) May 15, 2024 15:58
@mattcreaser mattcreaser merged commit 9f900a0 into main May 15, 2024
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/logger-ktx branch May 15, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants