Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): Make Analytics Options Builder build function public for Java to call #2804

Merged
merged 1 commit into from
May 6, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #2802

Description of changes:
Analytics Options Builder should have had a public build method. While it's not needed for Kotlin it is needed for Java.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update) - Docs to be updated once released

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser added the analytics Related to the Analytics category/plugins label May 3, 2024
@mattcreaser mattcreaser requested review from a team as code owners May 3, 2024 21:43
@tylerjroach tylerjroach merged commit 7c75b0f into main May 6, 2024
4 checks passed
@tylerjroach tylerjroach deleted the mattcreaser/analytics-option-builder branch May 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics Related to the Analytics category/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants