Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): Re-add option to track lifecyle events #2788

Merged

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Adds trackLifecycleEvents to analytics plugin options
  • Re-adds code that had been removed to read trackLifecycleEvents from Gen1 config
  • Fixes implementation to respect the value of trackLifecycleEvents

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners April 23, 2024 21:25
@mattcreaser
Copy link
Member Author

Note: the parsing for the trackLifecycleEvents was removed in #2762

@mattcreaser mattcreaser merged commit 4e65b8c into feat/gen2-config Apr 24, 2024
@mattcreaser mattcreaser deleted the mattcreaser/gen2-config-analytics-autotrack branch April 24, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants