Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Fix incorrect statement about when userId is returned in AuthSignUpResult #2782

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

tylerjroach
Copy link
Member

@tylerjroach tylerjroach commented Apr 19, 2024

  • PR title and description conform to Pull Request guidelines.
  • [ ]

Issue #, if available:
#2775

Description of changes:
userId is not returned in AuthSignUpResult for confirmSignUp as it is not returned to us from the API. Cognito will only return userId on signUp calls.

We can't be more specific on this class, because AuthSignUpResult is in core, and a non-Cognito auth library may have different behavior as to when userId is and isn't returned.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach marked this pull request as ready for review April 19, 2024 16:39
@tylerjroach tylerjroach requested a review from a team as a code owner April 19, 2024 16:39
@tylerjroach tylerjroach merged commit 916a3bb into main Apr 23, 2024
5 checks passed
@tylerjroach tylerjroach deleted the tjroach/correct-signup-documentation branch April 23, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants