Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): Backport Gen2 config to Gen1 JSON for older authenticator versions #2768

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • When using Gen2 config we will rebuild the Gen1 JSON blob for use by older versions of Authenticator that haven't been updated to use the AuthConfiguration directly.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner April 15, 2024 15:20
@mattcreaser mattcreaser force-pushed the mattcreaser/gen2-config-auth branch from 882c2dd to 6ae0bbb Compare April 15, 2024 15:25
@mattcreaser mattcreaser requested a review from a team as a code owner April 15, 2024 15:25
@mattcreaser mattcreaser force-pushed the mattcreaser/gen2-config-auth-json branch from bbd6c70 to 4dc7727 Compare April 15, 2024 15:26
@mattcreaser mattcreaser added the auth Related to the Auth category/plugins label Apr 15, 2024
@tylerjroach
Copy link
Member

Gen2 will be a minor version bump. We don't claim to support older versions of authenticator with a minor version bump on Amplify (see https://github.com/aws-amplify/amplify-ui-android?tab=readme-ov-file#supported-versions).

This is a decent bit of extra code to maintain, and very temporary in its usage. Thoughts on not providing this mechanism at all?

@tylerjroach
Copy link
Member

After discussing, looks like we should support this.

@mattcreaser mattcreaser force-pushed the mattcreaser/gen2-config-auth branch from 6ae0bbb to 62d3326 Compare April 16, 2024 19:47
@mattcreaser mattcreaser force-pushed the mattcreaser/gen2-config-auth-json branch from 4dc7727 to 9ea76cd Compare April 16, 2024 19:50
Base automatically changed from mattcreaser/gen2-config-auth to feat/gen2-config April 17, 2024 13:46
@mattcreaser mattcreaser force-pushed the mattcreaser/gen2-config-auth-json branch from 9ea76cd to 2b93fa7 Compare April 17, 2024 13:48
@mattcreaser mattcreaser merged commit faba208 into feat/gen2-config Apr 17, 2024
@mattcreaser mattcreaser deleted the mattcreaser/gen2-config-auth-json branch April 17, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Related to the Auth category/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants