-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): Gen2 Implementation for getUrl, remove, list #2755
feat(storage): Gen2 Implementation for getUrl, remove, list #2755
Conversation
…pload # Conflicts: # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/AWSS3StoragePlugin.java # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/extensions/StorageExceptionExtensions.kt # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StorageDownloadFileOperation.kt # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StorageGetPresignedUrlOperation.java # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StorageListOperation.java # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StoragePathDownloadFileOperation.kt # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StorageRemoveOperation.java # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StorageUploadFileOperation.kt # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StorageUploadInputStreamOperation.kt # core-kotlin/src/test/java/com/amplifyframework/kotlin/storage/KotlinStorageFacadeTest.kt # core/src/main/java/com/amplifyframework/storage/StoragePath.kt # core/src/main/java/com/amplifyframework/storage/StoragePathValidationException.kt # core/src/main/java/com/amplifyframework/storage/result/StorageUploadFileResult.java
…-geturl-remove-list
…gen2-geturl-remove-list # Conflicts: # aws-storage-s3/src/androidTest/java/com/amplifyframework/storage/s3/AWSS3StoragePathDownloadTest.kt # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/AWSS3StoragePlugin.java # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/extensions/StoragePath.kt # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StorageDownloadFileOperation.kt # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StoragePathDownloadFileOperation.kt # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StoragePathUploadFileOperation.kt # aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/operation/AWSS3StoragePathUploadInputStreamOperation.kt # testutils/src/main/java/com/amplifyframework/testutils/sync/SynchronousStorage.java
@@ -73,6 +75,7 @@ public AWSS3StorageRemoveOperation( | |||
this.awsS3StoragePluginConfiguration = awsS3StoragePluginConfiguration; | |||
} | |||
|
|||
@OptIn(markerClass = InternalAmplifyApi.class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to opt-in via compiler flags for Java similarly to how we do it for Kotlin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been able to find any references that would support this.
Issue #, if available:
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.