Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where unauthenticated logins caused 401 because refresh caused new credentials to be created #2752

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Fix issue where unauthenticated logins caused 401 because refresh caused new credentials to be created #2752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
114fb8f
Add identity ID to RefreshUnAuthSession
marcoatblueowl Apr 3, 2024
c0af386
Update RefreshSessionEvent to use Identity ID
marcoatblueowl Apr 3, 2024
277dfff
Update RefreshUnAuthSession to use fetchAWSCredentialsAction instead …
marcoatblueowl Apr 3, 2024
42a2129
Merge branch 'main' into patch-1
mattcreaser Apr 5, 2024
5d7ae0e
Made changes based on the style guide
Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...to/src/main/java/com/amplifyframework/auth/cognito/actions/AuthorizationCognitoActions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ internal object AuthorizationCognitoActions : AuthorizationActions {
RefreshSessionEvent.EventType.RefreshUserPoolTokens(amplifyCredential.signedInData)
)
is AmplifyCredential.IdentityPool -> RefreshSessionEvent(
RefreshSessionEvent.EventType.RefreshUnAuthSession(LoginsMapProvider.UnAuthLogins())
RefreshSessionEvent.EventType.RefreshUnAuthSession(
amplifyCredential.identityId,
LoginsMapProvider.UnAuthLogins()
)
)
is AmplifyCredential.IdentityPoolFederated -> {
AuthorizationEvent(
Expand Down
2 changes: 1 addition & 1 deletion ...ito/src/main/java/com/amplifyframework/statemachine/codegen/events/RefreshSessionEvent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ internal class RefreshSessionEvent(val eventType: EventType, override val time:
sealed class EventType {
data class RefreshUserPoolTokens(val signedInData: SignedInData) : EventType()
data class RefreshAuthSession(val signedInData: SignedInData, val logins: LoginsMapProvider) : EventType()
data class RefreshUnAuthSession(val logins: LoginsMapProvider) : EventType()
data class RefreshUnAuthSession(val identityId: String, val logins: LoginsMapProvider) : EventType()
data class Refreshed(val signedInData: SignedInData) : EventType()
}

Expand Down
15 changes: 13 additions & 2 deletions ...ito/src/main/java/com/amplifyframework/statemachine/codegen/states/RefreshSessionState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,19 @@ internal sealed class RefreshSessionState : State {
StateResolution(RefreshingUserPoolTokens(refreshSessionEvent.signedInData), listOf(action))
}
is RefreshSessionEvent.EventType.RefreshUnAuthSession -> {
val action = fetchAuthSessionActions.refreshAuthSessionAction(refreshSessionEvent.logins)
StateResolution(RefreshingUnAuthSession(FetchAuthSessionState.NotStarted()), listOf(action))
val action = fetchAuthSessionActions.fetchAWSCredentialsAction(
refreshSessionEvent.identityId,
refreshSessionEvent.logins
)
StateResolution(
RefreshingUnAuthSession(
FetchAuthSessionState.FetchingAWSCredentials(
refreshSessionEvent.identityId,
refreshSessionEvent.logins
)
),
listOf(action)
)
}
else -> defaultResolution
}
Expand Down
Loading