-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): Expose AuthConfiguration directly #2740
feat(auth): Expose AuthConfiguration directly #2740
Conversation
...th-cognito/src/main/java/com/amplifyframework/statemachine/codegen/data/AuthConfiguration.kt
Outdated
Show resolved
Hide resolved
...th-cognito/src/main/java/com/amplifyframework/statemachine/codegen/data/AuthConfiguration.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2740 +/- ##
==========================================
+ Coverage 42.92% 43.02% +0.10%
==========================================
Files 905 905
Lines 29127 29178 +51
Branches 4144 4152 +8
==========================================
+ Hits 12503 12555 +52
+ Misses 15268 15265 -3
- Partials 1356 1358 +2 |
Looks good, but thoughts on removing the Java style builders since those are all internal? |
The builders are only used from tests and could be removed, but I'd do that separately to avoid bloating this PR. |
Issue #, if available:
Description of changes:
Amplify previously exposed raw JSON via
getPluginConfiguration
for Authenticator to consume. This change instead exposed a pre-parsedAuthConfiguration
.signupAttributes
,usernameAttributes
,verificationMechanisms
, andpasswordProtectionSettings
toAuthConfiguration
AuthConfiguration
and related types with@InternalAmplifyApi
annotations.getPluginConfiguration
function.AuthConfiguration
tocom.amplifyframework.auth.cognito
package. This is a more appropriate location for this class.Equivalent Swift PR is here: aws-amplify/amplify-swift#3566
How did you test these changes?
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.