Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Add userAttributes to confirmSignIn call #2640

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

tylerjroach
Copy link
Member

@tylerjroach tylerjroach commented Nov 17, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2622

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner November 17, 2023 20:05
@tylerjroach tylerjroach marked this pull request as draft November 17, 2023 20:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Merging #2640 (a0ac3d1) into main (644be2d) will increase coverage by 0.02%.
The diff coverage is 44.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2640      +/-   ##
==========================================
+ Coverage   41.78%   41.80%   +0.02%     
==========================================
  Files         902      902              
  Lines       28976    28996      +20     
  Branches     4106     4107       +1     
==========================================
+ Hits        12107    12122      +15     
- Misses      15543    15544       +1     
- Partials     1326     1330       +4     

@tylerjroach tylerjroach merged commit 3f2ea63 into main Nov 21, 2023
3 checks passed
@tylerjroach tylerjroach deleted the tjroach/fix-confirm-sign-in-with-attributes branch November 21, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants