feat(auth): Added the api shells for signin and confirmsignin for passwordless #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpanshu
changed the title
core/src/main/java/com/amplifyframework/auth/AuthPasswordlessDeliveryDestination.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplifyframework/auth/AuthPasswordlessFlow.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplifyframework/auth/AuthPasswordlessFlow.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplifyframework/auth/options/AuthOTPOptions.java
Outdated
Show resolved
Hide resolved
...nito/src/main/java/com/amplifyframework/auth/cognito/options/AWSCognitoAuthWithOTPOptions.kt
Outdated
Show resolved
Hide resolved
thisisabhash
approved these changes
Nov 17, 2023
core/src/main/java/com/amplifyframework/auth/AuthPasswordlessFlow.java
Outdated
Show resolved
Hide resolved
harsh62
reviewed
Nov 20, 2023
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/AWSCognitoAuthPlugin.kt
Show resolved
Hide resolved
harsh62
reviewed
Nov 20, 2023
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/RealAWSCognitoAuthPlugin.kt
Show resolved
Hide resolved
tylerjroach
requested changes
Nov 21, 2023
...rc/main/java/com/amplifyframework/auth/cognito/options/AWSCognitoAuthWithMagicLinkOptions.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/amplifyframework/auth/cognito/options/AWSCognitoAuthWithMagicLinkOptions.kt
Outdated
Show resolved
Hide resolved
| * Get user attributes to be sent to the service such as information about the user | ||
| * @return user attributes to be sent to the service such as information about the user | ||
| */ | ||
| val userMetadata: Map<String, String>? |
There was a problem hiding this comment.
no reason for this to be null when its impossible for builder to pass null.
...nito/src/main/java/com/amplifyframework/auth/cognito/options/AWSCognitoAuthWithOTPOptions.kt
Outdated
Show resolved
Hide resolved
rxbindings/src/main/java/com/amplifyframework/rx/RxAuthCategoryBehavior.java
Show resolved
Hide resolved
core/src/main/java/com/amplifyframework/auth/AuthPasswordlessDeliveryDestination.java
Outdated
Show resolved
Hide resolved
tylerjroach
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.