-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(liveness): Liveness web socket expiration retry #2615
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #2615 +/- ##
==========================================
+ Coverage 41.72% 41.77% +0.04%
==========================================
Files 900 901 +1
Lines 28870 28965 +95
Branches 4105 4102 -3
==========================================
+ Hits 12047 12100 +53
- Misses 15494 15538 +44
+ Partials 1329 1327 -2 |
.../main/java/com/amplifyframework/predictions/aws/models/liveness/InvalidSignatureException.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments added
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
… plugin version; reimplement bytearraycontent
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Show resolved
Hide resolved
...predictions/src/test/java/com/amplifyframework/predictions/aws/http/LivenessWebSocketTest.kt
Outdated
Show resolved
Hide resolved
...predictions/src/test/java/com/amplifyframework/predictions/aws/http/LivenessWebSocketTest.kt
Show resolved
Hide resolved
...predictions/src/test/java/com/amplifyframework/predictions/aws/http/LivenessWebSocketTest.kt
Show resolved
Hide resolved
...predictions/src/test/java/com/amplifyframework/predictions/aws/http/LivenessWebSocketTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see Ankit's date parsing concern. Outside of this, I am ok with PR.
Issue #, if available:
Description of changes:
If device time is out of sync with true server time, skew the time sent to the Liveness websocket by that offset (calculated via server response vs. device time) and retry.
How did you test these changes?
tested on gamma where liveness team has implemented the header.
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.