fix(auth): Fix for retry sign in when resourceNotFoundException is raised

[gpanshu]

• PR title and description conform to Pull Request guidelines.

Issue #, if available: #2603

Description of changes: Reported via JS team. After signing in and calling rememberDevice(), calling forgetDevice(id) on another device or manually forgetting the device via Cognito leads to the device being unable to sign in. The issue is that the original device still has the deviceMetadata and deviceId and provides it to Cognito, which no longer recognizes it as valid. The error we get back from Cognito is ResourceNotFoundException{message=Could not find the requested online resource., cause=ResourceNotFoundException(message=Device does not exist.)}. Swift/Flutter apparently have retries in place to catch this and resubmit without the device metadata.

How did you test these changes?
Manually and integration tested

Documentation update required?

• No
• Yes (Please include a PR link for the documentation update)

General Checklist

• Added Unit Tests
• Added Integration Tests
• Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[tjleing]

approving because the code looks the way I would expect code that fixes this issue to look and because the tests look like they properly test the feature. not huge due diligence here, I'm not an auth expert

[codecov-commenter]

Codecov Report

Merging #2605 (e47d420) into main (7cba616) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 19.67%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2605      +/-   ##
==========================================
- Coverage   41.76%   41.73%   -0.03%     
==========================================
  Files         900      900              
  Lines       28814    28852      +38     
  Branches     4093     4098       +5     
==========================================
+ Hits        12033    12041       +8     
- Misses      15463    15488      +25     
- Partials     1318     1323       +5     

[tylerjroach]

"After signing in and calling rememberDevice(), calling forgetDevice(id) on another device or manually forgetting the device via Cognito leads to the device being unable to sign in."

Can you clarify this? Is the user unable to sign in again after a sign out? Or does this impact their signed in user.

Does this behavior now match Swift exactly?

[gpanshu]

"After signing in and calling rememberDevice(), calling forgetDevice(id) on another device or manually forgetting the device via Cognito leads to the device being unable to sign in."

Can you clarify this? Is the user unable to sign in again after a sign out? Or does this impact their signed in user.
If the device ID is forgotten either through the console or through another session of the same user, after logout if they login on the same device whose deviceID was forgotten they will get a resourceNotFoundException which is now mitigated by this logic add.

Does this behavior now match Swift exactly?
Yes it does exactly match Swift now.