Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Lazy Loading and Custom Selection Set #2592

Merged
merged 112 commits into from
Oct 10, 2023
Merged

feat(api): Lazy Loading and Custom Selection Set #2592

merged 112 commits into from
Oct 10, 2023

Conversation

tylerjroach
Copy link
Member

@tylerjroach tylerjroach commented Sep 21, 2023 •
edited
Loading

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

We are introducing Lazy Loading and Custom Selection Set support to API category. The necessary model updates are here: aws-amplify/amplify-codegen#699.

The feature will initially require opting-in from the cli by setting the existing generatemodelsforlazyloadandcustomselectionset flag to true.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

eeatonaws and others added 30 commits June 1, 2023 13:01
@eeatonaws
add lazy loading for api
476f5b8
@tylerjroach
Allow passing ModelIdentifier for querying based on CPK
8460163
@tylerjroach
Share RequestFactory work between API and DataStore
017ac0a
@tylerjroach
Mark helper to Amplify Internal
43edd8d
@tylerjroach
checkstyle
1a6e010
@tylerjroach
Add CPK ModelQuery test
a5b63ad
@tylerjroach
Code cleanup
4f8b9c5
@tylerjroach
fix test
c71680f
@tylerjroach
Merge branch 'main' into tjroach/cpk-api
d4c8540
@tylerjroach
GSON serializer should decide how to insert. Inserting as string is i…
a3666d2 
…ncorrect for many types
@tylerjroach
Merge remote-tracking branch 'origin/tjroach/cpk-api' into tjroach/cp…
f189db6 
…k-api
@tylerjroach
Temporal Date/Times need to be Serializable to support usage as sort key
bc26c47
@tylerjroach
Add CPK API CRUD request tests
5a440e4
@tylerjroach
lint
b9d8b51
@tylerjroach
CPK testing
6717c54
@tylerjroach
allow setting null association
36edbac
@tylerjroach
Update how associations are handled in create and update mutations.
121e3ea
@tylerjroach
Add test for updating nullable relation
0e08245
@tylerjroach
Test file rename and lint
50962d3
@tylerjroach
lint
23a6ee3
@tylerjroach
Merge branch 'main' into tjroach/cpk-api
ad538f4
@eeatonaws
retrieve items from lazy list
59afe46
@tylerjroach
allow query by id to figure out proper name and type
b706c42
@tylerjroach
Merge remote-tracking branch 'origin/tjroach/cpk-api' into tjroach/cp…
665fbab 
…k-api
@eeatonaws
remove unnecessary changes
1201715
@tylerjroach
Fix getPrimaryKey SQLiteColumn to properly return CPK with no sort key
8b52b40
@eeatonaws
Merge branch 'main' into api-lazy-loading
822ad20
@eeatonaws
Merge branch 'tjroach/cpk-api' into api-lazy-loading
2098bae
@eeatonaws
save lazy model id in create mutation for belongs to relationship
e28b570
@eeatonaws
include associated lazy model id when updating model
8767d42
@tylerjroach tylerjroach marked this pull request as ready for review September 29, 2023 20:13
@tylerjroach tylerjroach requested a review from a team as a code owner September 29, 2023 20:13
mattcreaser
mattcreaser reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@mattcreaser mattcreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

aws-api/build.gradle.kts Show resolved Hide resolved
testmodels/src/test/java/com/amplifyframework/testmodels/lazy/LazyTypeTest.kt Outdated Show resolved Hide resolved
core/src/test/java/com/amplifyframework/core/model/SchemaRegistryUtilsTest.kt Show resolved Hide resolved
core/src/main/java/com/amplifyframework/core/model/SchemaRegistryUtils.kt Outdated Show resolved Hide resolved
core/src/main/java/com/amplifyframework/core/model/LoadedModelReferenceImpl.kt Show resolved Hide resolved
aws-api/src/main/java/com/amplifyframework/api/aws/ModelPostProcessingTypeAdapter.kt Outdated Show resolved Hide resolved
aws-api/src/main/java/com/amplifyframework/api/aws/LazyTypeDeserializers.kt Show resolved Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/GraphQLRequestHelper.java Outdated Show resolved Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/GraphQLRequestHelper.java Show resolved Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/SelectionSetExtensions.kt Outdated Show resolved Hide resolved
ankpshah
ankpshah reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@ankpshah ankpshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

aws-api-appsync/src/main/java/com/amplifyframework/api/aws/GraphQLRequestHelper.java Show resolved Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/GraphQLRequestHelper.java Show resolved Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/GraphQLRequestHelper.java Show resolved Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/GraphQLRequestHelper.java Show resolved Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/SelectionSet.java Show resolved Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/SelectionSetExtensions.kt Show resolved Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/SelectionSetExtensions.kt Show resolved Hide resolved
aws-api/src/main/java/com/amplifyframework/api/aws/ApiLazyModelReference.kt Show resolved Hide resolved
aws-api/src/main/java/com/amplifyframework/api/aws/ApiModelListTypes.kt Outdated Show resolved Hide resolved
aws-api/src/main/java/com/amplifyframework/api/aws/ApiLazyModelReference.kt Outdated Show resolved Hide resolved
@ankpshah ankpshah self-requested a review October 4, 2023 22:25
mattcreaser
mattcreaser previously approved these changes Oct 5, 2023
View reviewed changes
ankpshah
ankpshah previously approved these changes Oct 5, 2023
View reviewed changes
@tylerjroach tylerjroach dismissed stale reviews from ankpshah and mattcreaser via bc19309 October 10, 2023 20:11
@tylerjroach tylerjroach enabled auto-merge (squash) October 10, 2023 20:55
@tylerjroach tylerjroach merged commit 7cc9826 into main Oct 10, 2023
4 checks passed
@tylerjroach tylerjroach deleted the tjroach/custom-selection-set branch October 10, 2023 22:09
gpanshu pushed a commit that referenced this pull request Oct 23, 2023
@tylerjroach @eeatonaws @gpanshu
feat(api): Lazy Loading and Custom Selection Set (#2592)
cc972e5 
Co-authored-by: Erica Eaton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpanshu gpanshu gpanshu approved these changes

@ankpshah ankpshah ankpshah approved these changes

@mattcreaser mattcreaser mattcreaser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tylerjroach @codecov-commenter @mattcreaser @ankpshah @gpanshu @eeatonaws