fix(liveness): API to add liveness version to websocket #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
mattcreaser
reviewed
Aug 30, 2023
...predictions/src/test/java/com/amplifyframework/predictions/aws/http/LivenessWebSocketTest.kt
Outdated
Show resolved
Hide resolved
tylerjroach
reviewed
Aug 30, 2023
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/AWSPredictionsPlugin.java
Outdated
Show resolved
Hide resolved
aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt
Outdated
Show resolved
Hide resolved
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #2572 +/- ##
=======================================
Coverage 41.23% 41.24%
=======================================
Files 885 885
Lines 28240 28246 +6
Branches 3993 3994 +1
=======================================
+ Hits 11646 11650 +4
- Misses 15310 15312 +2
Partials 1284 1284 |
tylerjroach
previously approved these changes
Sep 11, 2023
tylerjroach
approved these changes
Sep 11, 2023
ankpshah
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.