-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass parameter overrides as prefixed environment variables #105
Open
radekl
wants to merge
9
commits into
aws-actions:master
Choose a base branch
from
radekl:feat/env-as-params
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually solves some of the already existing issues too:
|
@kddejong can I have a little bit of your attention here? 😄 |
radekl
force-pushed
the
feat/env-as-params
branch
from
February 21, 2024 09:57
c74a28e
to
ab4800e
Compare
Force pushed all the commits to rebase and update to the changes in tests. |
@kddejong Hey, any chances for you to look into it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: -
Description of changes:
I have added a feature that allows users to use action's prefixed environment variables as parameter overrides. The prefix of environment key is removed before passing it to cloudformation.
This approach is based on Heroku Deploy action and addresses couple of issues including:
I have added feature, tests and documentation snippet. Feature should be backward compatible as it's only activated if user adds an
envs-prefix-for-parameter-overrides
parameter with a desired prefix.I hope that you will find this feature useful and include it in the main release.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.