Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass parameter overrides as prefixed environment variables #105

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

radekl
Copy link

@radekl radekl commented Jul 12, 2023

Issue #, if available: -

Description of changes:

I have added a feature that allows users to use action's prefixed environment variables as parameter overrides. The prefix of environment key is removed before passing it to cloudformation.

This approach is based on Heroku Deploy action and addresses couple of issues including:

  • a lot of parameters to override
  • sensitive inputs are not stored on disk/in the file
  • values of parameters passed to action using this way are automatically escaped - no need for additional escape, especially if using Github vars/secrets - whatever github accepts will be passed as parameters.

I have added feature, tests and documentation snippet. Feature should be backward compatible as it's only activated if user adds an envs-prefix-for-parameter-overrides parameter with a desired prefix.

I hope that you will find this feature useful and include it in the main release.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@radekl
Copy link
Author

radekl commented Jul 12, 2023

Actually solves some of the already existing issues too:

@radekl
Copy link
Author

radekl commented Feb 21, 2024

@kddejong can I have a little bit of your attention here? 😄

@radekl
Copy link
Author

radekl commented Feb 21, 2024

Force pushed all the commits to rebase and update to the changes in tests.

@radekl
Copy link
Author

radekl commented Aug 9, 2024

@kddejong Hey, any chances for you to look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant