-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated es.yml file #413
Updated es.yml file #413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this pull request! There are a number of corrections that need to be made before I can merge this in: There are some translations that just seemed to get mangled, some pieces that were changed but shouldn't have, and then a small question or two.
Please let me know if you need any clarifications or have any questions.
config/locales/es.yml
Outdated
@@ -1,4 +1,4 @@ | |||
es: | |||
en: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not have changed from es
config/locales/es.yml
Outdated
apply-for-grant: Solicita una beca | ||
inactive-chapter: Este capítulo está inactivo. | ||
inactive-chapter-reason: Un capítulo inactivo es uno que no ha otorgado una beca en seis meses. Si estás interesado en reiniciar este capítulo, por favor <a href="mailto:[email protected]">comunícate con nosotros</a>. | ||
inactive-chapter-reason: Un capítulos inactivo es uno que no ha otorgado una beca en seis meses. Si estás interesado en reiniciar este capítulo, por favor <a href="mailto:[email protected]">comunícate con nosotros</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming - is this correct since it is referring to a single chapter, not multiples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had that incorrect, sorry. I changed it to reflect capitulo
config/locales/es.yml
Outdated
@@ -108,10 +109,20 @@ es: | |||
end-date: fecha final | |||
table: | |||
title: Título | |||
id: Identificación | |||
id: IIdentificaciónD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what happened here but this is wrong
config/locales/es.yml
Outdated
description: Simplemente completa la solicitud a continuación con información sobre tí y los detalles de tu proyecto. | ||
apply: Solicita | ||
description: Simplemente completa la solicitud a continuación con información sobre tí y los detalles de tu proyecto. | ||
apply: AppSolicitaly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it got a bit mangled
config/locales/es.yml
Outdated
existing_chapters_header: Mira los capítulos existentes | ||
existing_chapters_text: Hay los capítulos de Awesome Foundation alrededor del mundo si es posible que ya hay un capítulo en su área. Mira el menú de "Capítulos" encima a ver si hay uno, y ponerse en contacto con ellos si ves uno cerca. | ||
handbook_header: Descargar el manual | ||
handbook_text: To help you get started, we collected the wisdom we've gained from giving out thousands of grants since 2009 and put it in our [New Chapter Handbook](http://wiki.awesomestudies.org/images/9/92/Awesome_Foundation_New_Chapter_Handbook.pdf). Para ayudarlo a comenzar, recogimos la sabiduría hemos ganado dando miles de subvenciones desde 2009 y ponerlo en nuestro [Nuevo manual de capítulos](http://wiki.awesomestudies.org/images/9/92/Awesome_Foundation_New_Chapter_Handbook.pdf). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still has the english text in place
config/locales/es.yml
Outdated
email_address: Dirección de Email | ||
hide_trustees: Ocultar administradores | ||
country: País | ||
time_zone: Zona horaria |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should not have been removed.
config/locales/es.yml
Outdated
projects: | ||
wait-for-uploads-to-complete: Por favor espera a que tus imágenes terminen de subir antes de someter tu solicitud. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a stray newline was added
package-lock.json
Outdated
@@ -0,0 +1,3 @@ | |||
{ | |||
"lockfileVersion": 1 | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added? This has nothing to do with the translation and should not be part of this commit.
@stroudn1 Hi! I am following up to see whether you have had a chance to review these requested changes. I would love to get your contributions merged into master. |
Hi @jcn - I apologize this is taking me so long. I haven't been on recently due to my mom having a stroke and she passed away Sunday. This week I'll be making arrangements but I'd like to take time to work on these changes this week or next if that's okay but I understand you need these done. Please let me know what you think. So sorry for the delay. |
RE: Start a New Chapter translations needed #405 Changed en back to es I'm not sure what happened with some of these and I apologize with the huge delay but appreciate your patience. I'm also not sure what happened as far as the package-lock.json piece but tried removing it and submitting the changes. If you see anything else that needs fixed, please let me know - I'm happy to help. And thank you for the opportunity to let me submit PRs for this. Have a good one! |
@stroudn1 I'm so very sorry for your loss, and thanks so much for the update; no worries at all about the timing, obviously. I just pushed a fix to the YAML file that was preventing it from being parsed properly and will be reviewing the translation as soon as possible. |
RE: Start a New Chapter translations needed #405
Pulled en.yml file from issue 405