-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed option :raw to true as default. #191
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,11 +31,11 @@ def cast_with_active_record(object, type) | |
|
||
# Format ActiveRecord instance object. | ||
# | ||
# NOTE: by default only instance attributes (i.e. columns) are shown. To format | ||
# ActiveRecord instance as regular object showing its instance variables and | ||
# accessors use :raw => true option: | ||
# NOTE: by default ActiveRecord instances are formatted as regular objects showing | ||
# its instance variables and accessors. To format with only instance attributes | ||
# (i.e. columns) use :raw => false option: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the AR need to keep his beahvior too. |
||
# | ||
# ap record, :raw => true | ||
# ap record, :raw => false | ||
# | ||
#------------------------------------------------------------------------------ | ||
def awesome_active_record_instance(object) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,11 +54,11 @@ def awesome_mongo_mapper_class(object) | |
|
||
# Format MongoMapper instance object. | ||
# | ||
# NOTE: by default only instance attributes (i.e. keys) are shown. To format | ||
# MongoMapper instance as regular object showing its instance variables and | ||
# accessors use :raw => true option: | ||
# NOTE: by default MongoMapper instances are formatted as regular objects showing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same that AR. |
||
# its instance variables and accessors. To format with only instance attributes | ||
# (i.e. keys) use :raw => false option: | ||
# | ||
# ap record, :raw => true | ||
# ap record, :raw => false | ||
# | ||
#------------------------------------------------------------------------------ | ||
def awesome_mongo_mapper_instance(object) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,10 +29,11 @@ def cast_with_ripple(object, type) | |
|
||
# Format Ripple instance object. | ||
# | ||
# NOTE: by default only instance attributes are shown. To format a Ripple document instance | ||
# as a regular object showing its instance variables and accessors use :raw => true option: | ||
# NOTE: by default Ripple document instances are formatted as regular objects showing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same that AR. |
||
# its instance variables and accessors. To format with only instance attributes | ||
# use :raw => false option: | ||
# | ||
# ap document, :raw => true | ||
# ap document, :raw => false | ||
# | ||
#------------------------------------------------------------------------------ | ||
def awesome_ripple_document_instance(object) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need to change defaults, since this is a breaking change and brokes the semantic versioning.