Implement parsing of value groups #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue avr-rust#1
dylanmckay
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
I completely lost track of your two PRs, this one looks good to me.
I feel the code may be a little messy. Feedback would be appreciated.
It doesn't look messy to me, nothing sticks out, although I might have added a couple more empty lines just to pad out the wall of code, nothing that really matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the parsing of value groups. Because the values in value groups represent a group, I have generated modules with constants.
I feel the code may be a little messy. Feedback would be appreciated.
This PR fixes issue #1.