-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
67 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,7 @@ further defined and clarified by project maintainers. | |
## Enforcement | ||
|
||
Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
reported by contacting the project team at {{ email }}. All | ||
reported by contacting the project team at [[email protected]](mailto:[email protected]). All | ||
complaints will be reviewed and investigated and will result in a response that | ||
is deemed necessary and appropriate to the circumstances. The project team is | ||
obligated to maintain confidentiality with regard to the reporter of an incident. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Contributing Guidelines | ||
|
||
Thank you for your interest in contributing to our project. Whether it's a bug report, new feature, correction, or additional | ||
documentation, we greatly value feedback and contributions from our community. | ||
|
||
Please read through this document before submitting any issues or pull requests to ensure we have all the necessary | ||
information to effectively respond to your bug report or contribution. | ||
|
||
## Table of Contents | ||
1. [Reporting Bugs/Feature Requests](#Reporting) | ||
2. [Contributing via Pull Requests](#Pulls) | ||
3. [Style and Formatting](#Style) | ||
|
||
## Reporting Bugs/Feature Requests <a name="Reporting"></a> | ||
|
||
We welcome you to use the GitHub issue tracker to report bugs or suggest features. | ||
|
||
When filing an issue, please check [existing open](https://github.com/avishayil/cdk-goat/issues), or [recently closed](https://github.com/avishayil/cdk-goat/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), issues to make sure somebody else hasn't already reported the issue. Please try to include as much information as you can. Details like these are incredibly useful: | ||
|
||
* A reproducible test case or series of steps | ||
* The version of our code being used | ||
* Any modifications you've made relevant to the bug | ||
* Anything unusual about your environment or deployment | ||
|
||
## Contributing via Pull Requests <a name="Pulls"></a> | ||
|
||
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that: | ||
|
||
1. You are working against the latest source on the *master* branch. | ||
2. You check existing open, and recently merged, pull requests to make sure someone else hasn't addressed the problem already. | ||
|
||
To send us a pull request, please: | ||
|
||
1. Fork the repository. | ||
2. Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change. | ||
3. Ensure your changes passes `cdk synth` or indicate in the PR why it does not. | ||
4. Ensure local tests pass automated tests (by running `pytest -v`) | ||
5. Add any relevant test to keep the CDK application in high coverage rate for vulnerable resources. | ||
6. Commit to your fork using clear commit messages. | ||
7. Send us a pull request, answering any default questions in the pull request interface. | ||
8. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation. | ||
|
||
GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and | ||
[creating a pull request](https://help.github.com/articles/creating-a-pull-request/). | ||
|
||
## Style and Formatting <a name="Style"></a> | ||
|
||
We strive to keep consistent in style and formatting. This hopefully makes navigating CDK Goat easier for users. | ||
|
||
CDK Goat uses `Python 3.7.16` as a programming language and `flake8`, `black`, `isort` as code style linters. You can ensure the linters run smoothly by: | ||
- Installing dev dependencies by running `poetry install --sync` | ||
- Installing pre-commit environment by running `pre-commit install` | ||
- Running linters and automated fixes by running `pre-commit run -a` | ||
|
||
We thank you for your contribution and look forward to cooperate with you on this exciting project for the good of all! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters