Implementing build for intel based macOS #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatejKastak
requested changes
Jan 4, 2024
|
Implemented the changes and the workflow runs now. :) |
MatejKastak
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect of #67 and affecting #14 partly, this pull request includes a few changes allowing to build yari on macOS x64. An example run can be seen here: https://github.com/3c7/yari/actions/runs/7396353584.
Somehow bindgen is able to derive
DebugforYR_SCAN_CONTEXTitself already, so the implementation in yari-sys/src/bindings.rs was limited to linux and windows systems. Additionally,link_linux()was renamed tolink_unix()and limited to both, linux and macos.In order to be able to use the bundled bindings, another set of bindings for macos was provided.