Merge pull request #44 from avast/ArgumentsPureconfigFix

Fix: declare/bind arguments are not strict about keys
avast · Feb 12, 2020 · 54efe29 · 54efe29
2 parents 0f3d0c2 + ec1eac5
commit 54efe29
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/core/src/test/resources/application.conf b/core/src/test/resources/application.conf
@@ -191,6 +191,8 @@ myConfig {
 
     declareQueue {
       name = "QUEUE2"
+
+      arguments = { "x-max-length" : 10000 }
     }
 
     bindQueue {

diff --git a/pureconfig/src/main/scala/com/avast/clients/rabbitmq/pureconfig/PureconfigImplicits.scala b/pureconfig/src/main/scala/com/avast/clients/rabbitmq/pureconfig/PureconfigImplicits.scala
@@ -59,6 +59,12 @@ class PureconfigImplicits(implicit namingConvention: NamingConvention = CamelCas
   private implicit def hint[T]: ProductHint[T] =
     ProductHint[T](ConfigFieldMapping(CamelCase, namingConvention), allowUnknownKeys = allowUnknownKeys)
 
+  private implicit val declareArgumentsHint: ProductHint[DeclareArgumentsConfig] =
+    ProductHint[DeclareArgumentsConfig](ConfigFieldMapping(CamelCase, namingConvention), allowUnknownKeys = true)
+
+  private implicit val bindArgumentsHint: ProductHint[BindArgumentsConfig] =
+    ProductHint[BindArgumentsConfig](ConfigFieldMapping(CamelCase, namingConvention), allowUnknownKeys = true)
+
   // connection, producer, consumers:
   implicit val connectionConfigReader: ConfigReader[RabbitMQConnectionConfig] = {
     if (!allowUnknownKeys) StrictConnectionConfigReader else deriveReader[RabbitMQConnectionConfig]