Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hindi and english language to the instrustion and inputform #164

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

ananyajain10
Copy link
Contributor

@ananyajain10 ananyajain10 commented Sep 6, 2024

Fixes #157
image

image

image

Summary

The method changes the application's locale dynamically using Vue's $i18n instance based on the selected language.
This change allows users to dynamically switch the language of the instruction page, improving the application's multilingual support.

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable, update docs/ENV.md, .env.example and the Github workflows.
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVG buttons without text have their aria-label attributes set

@VedantKhairnar
Copy link

Hello @suryabulusu
Will you pls review this PR?
Thanks.

src/main.ts Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/hi.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@suryabulusu suryabulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ananyajain10 Sorry, but these are not the instructions i was looking for. i should have referred to InstructionPage.vue specifically in the Issue.

We do not use FormInput or FormResults in Quiz Engine anymore.

But the structure seems mostly correct so it shouldn't take long to make these changes for InstructionPage.vue

Another suggestion: locales folder can have more meaningful file names instead of just en.json and hi.json

@ananyajain10
Copy link
Contributor Author

@ananyajain10 Sorry, but these are not the instructions i was looking for. i should have referred to InstructionPage.vue specifically in the Issue.

We do not use FormInput or FormResults in Quiz Engine anymore.

But the structure seems mostly correct so it shouldn't take long to make these changes for InstructionPage.vue

Another suggestion: locales folder can have more meaningful file names instead of just en.json and hi.json

image
image

General Instructions section multilingual support for InstructionPage.vue
Please check if the required changes are met.
Thank You

@suryabulusu
Copy link
Collaborator

It seems you have not pushed any of the changes @ananyajain10

@ananyajain10
Copy link
Contributor Author

It seems you have not pushed any of the changes @ananyajain10

I was waiting for you to let me know if these are the required changes.

@ananyajain10
Copy link
Contributor Author

@suryabulusu
Required changes are done. Please review.
image
image

src/router/index.ts Outdated Show resolved Hide resolved
@suryabulusu
Copy link
Collaborator

@ananyajain10 left more comments and made some changes. can you take a pull of the changes i made and fix few things? we can merge then.

Copy link
Collaborator

@suryabulusu suryabulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. made some more changes. merging soon. thanks @ananyajain10!

@suryabulusu suryabulusu merged commit f115970 into avantifellows:main Oct 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C4GT Community]: Multi-language compatibility
3 participants