-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added hindi and english language to the instrustion and inputform #164
added hindi and english language to the instrustion and inputform #164
Conversation
Hello @suryabulusu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ananyajain10 Sorry, but these are not the instructions i was looking for. i should have referred to InstructionPage.vue specifically in the Issue.
We do not use FormInput or FormResults in Quiz Engine anymore.
But the structure seems mostly correct so it shouldn't take long to make these changes for InstructionPage.vue
Another suggestion: locales folder can have more meaningful file names instead of just en.json and hi.json
General Instructions section multilingual support for InstructionPage.vue |
It seems you have not pushed any of the changes @ananyajain10 |
I was waiting for you to let me know if these are the required changes. |
@suryabulusu |
…0/quiz-frontend into add-language-support
@ananyajain10 left more comments and made some changes. can you take a pull of the changes i made and fix few things? we can merge then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. made some more changes. merging soon. thanks @ananyajain10!
Fixes #157
Summary
The method changes the application's locale dynamically using Vue's $i18n instance based on the selected language.
This change allows users to dynamically switch the language of the instruction page, improving the application's multilingual support.
Test Plan
Local Language Supportdocs/ENV.md
,.env.example
and the Github workflows.alt
attributes<img>
tags havewidth
andheight
specifiedtarget="_blank"
links haverel="noopener"
aria-label
attributes set