Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: error message for alphabets and multiple decimals #162

Merged
merged 6 commits into from
Aug 24, 2024

Conversation

kesharibhai84
Copy link
Contributor

Fixes #159

Summary

Error message for alphabets and multiple decimals added.

Test Plan

Error message for Multiple Decimal

image

Error message for Alphabets

image

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable, update docs/ENV.md, .env.example and the Github workflows.
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVG buttons without text have their aria-label attributes set

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 78.29457% with 56 lines in your changes missing coverage. Please review.

Project coverage is 79.29%. Comparing base (a406ea8) to head (dd2b17b).
Report is 23 commits behind head on main.

Files Patch % Lines
src/components/Omr/OmrItem.vue 78.83% 25 Missing and 4 partials ⚠️
src/components/Questions/Body.vue 77.68% 23 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   79.37%   79.29%   -0.09%     
==========================================
  Files          17       17              
  Lines        1411     1497      +86     
  Branches      415      462      +47     
==========================================
+ Hits         1120     1187      +67     
- Misses        255      273      +18     
- Partials       36       37       +1     
Flag Coverage Δ
chrome 79.29% <78.29%> (-0.09%) ⬇️
ui 79.29% <78.29%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@suryabulusu suryabulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@suryabulusu suryabulusu merged commit 7db3bb0 into avantifellows:main Aug 24, 2024
4 of 7 checks passed
@VedantKhairnar
Copy link

Hello @kesharibhai84 ,
Thanks for your contribution.
As part of Augtoberfest, we want to reward you for your contributions, so pls fill out this form by 19th Sept.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C4GT Community]: Add instructions / error when wrong characters are entered in numerical textbox
3 participants