Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Mark For Review button #150

Merged
merged 15 commits into from
Sep 21, 2024
Merged

Adds Mark For Review button #150

merged 15 commits into from
Sep 21, 2024

Conversation

suryabulusu
Copy link
Collaborator

@suryabulusu suryabulusu commented Jun 24, 2024

Summary

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable, update docs/ENV.md, .env.example and the Github workflows.
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVG buttons without text have their aria-label attributes set

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 67.64706% with 22 lines in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (9aa7314) to head (4054078).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/components/InstructionPage.vue 57.14% 5 Missing and 1 partial ⚠️
src/views/Player.vue 73.68% 5 Missing ⚠️
src/components/Questions/Footer.vue 60.00% 2 Missing and 2 partials ⚠️
src/components/Questions/QuestionModal.vue 75.00% 4 Missing ⚠️
src/components/Questions/Body.vue 62.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   72.50%   77.68%   +5.17%     
==========================================
  Files          59       17      -42     
  Lines        8445     1546    -6899     
  Branches      897      474     -423     
==========================================
- Hits         6123     1201    -4922     
+ Misses       2295      304    -1991     
- Partials       27       41      +14     
Flag Coverage Δ
chrome 77.68% <67.64%> (+5.17%) ⬆️
ui 77.68% <67.64%> (-1.76%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suryabulusu suryabulusu merged commit 5b18ab2 into main Sep 21, 2024
7 of 9 checks passed
@suryabulusu suryabulusu deleted the feat/mark-for-reviw branch September 21, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant