-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute time spent per question #137
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 73.87% 78.72% +4.84%
==========================================
Files 59 17 -42
Lines 7626 1349 -6277
Branches 801 394 -407
==========================================
- Hits 5634 1062 -4572
+ Misses 1970 287 -1683
+ Partials 22 0 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small change, then looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as far as I can tell. But I've lost context here :(
Fixes #123
Summary
We maintain an array
timeSpentPerQuestion[]
that has a length ofnumQuestions
.For each question in homework,
time_spent
is sent to backend with "Submit" button is clicked.For each question in assessment,
time_spent
is sent to backend when Save & Next button is clicked.In addition, we also send an update on
time_spent
on each question to backend every few seconds, along withdummy-event
. This helps keep track of the latest values oftimeSpentPerQuestion
(in case submit or save buttons are not clicked).Related ADR: https://www.notion.so/avantifellows/ADR-Time-Spent-Per-Question-211b3f4088894f8b96b471a787c2f073
Test Plan
Local Language SupportCheck for bundle size here if adding a packageAdded relevant details like Labels/Projects/Milestones etc.If adding or removing any environment variable, updatedocs/ENV.md
,.env.example
and the Github workflows.Lighthouse ChecksImages havealt
attributesAny<img>
tags havewidth
andheight
specifiedAnytarget="_blank"
links haverel="noopener"
Only SVGs are used as images. If PNGs are used, their size has been optimised.Any SVG buttons without text have theiraria-label
attributes set