Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several UI Updates #136

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Several UI Updates #136

merged 3 commits into from
Oct 23, 2023

Conversation

suryabulusu
Copy link
Collaborator

@suryabulusu suryabulusu commented Oct 23, 2023

Summary

  1. Display subjective/numerical correct answers under text box once quiz has ended. Solves Issue: Display correct answer for Numerical / Subjective Type post-submission #67
  2. Display green border for correct answers (but not chosen by the user). Solves Issue: Difference between skipped and correctly-answered questions in question body #120 Green outline for correct answer of a skipped question #128
  3. Reposition Back/Forward buttons. Solves Issue: Repositioning of QE buttons #126
  4. Change pop-up message before quiz ends. Solves Issue: Modify Label of Pop-Up Message #127

See notion for screenshots: https://www.notion.so/avantifellows/UI-Improvements-Differentiate-between-Selected-and-Saved-Answers-d99ab986f3c743c8a37467ad9e7835bb

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable, update docs/ENV.md, .env.example and the Github workflows.
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVG buttons without text have their aria-label attributes set

@suryabulusu suryabulusu temporarily deployed to Staging October 23, 2023 12:54 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c412973) 78.14% compared to head (7be1163) 73.87%.

❗ Current head 7be1163 differs from pull request most recent head 0822585. Consider uploading reports for the commit 0822585 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   78.14%   73.87%   -4.28%     
==========================================
  Files          17       59      +42     
  Lines        1304     7632    +6328     
  Branches      377      802     +425     
==========================================
+ Hits         1019     5638    +4619     
- Misses        285     1972    +1687     
- Partials        0       22      +22     
Flag Coverage Δ
chrome 73.87% <94.04%> (-4.28%) ⬇️
ui 77.61% <75.00%> (-0.53%) ⬇️
unittest 69.99% <90.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/components/Questions/Body.vue 95.23% <100.00%> (+20.62%) ⬆️
src/components/Questions/Footer.vue 100.00% <100.00%> (+17.64%) ⬆️
src/components/Questions/QuestionModal.vue 97.75% <100.00%> (+9.70%) ⬆️
src/components/Splash.vue 95.95% <0.00%> (+18.80%) ⬆️
src/components/Omr/OmrItem.vue 90.07% <85.71%> (+12.83%) ⬆️

... and 54 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suryabulusu suryabulusu temporarily deployed to Staging October 23, 2023 13:15 — with GitHub Actions Inactive
@suryabulusu suryabulusu temporarily deployed to Staging October 23, 2023 14:34 — with GitHub Actions Inactive
@suryabulusu suryabulusu merged commit af1990a into main Oct 23, 2023
7 checks passed
@suryabulusu suryabulusu deleted the ui-updates branch October 23, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant