[36] Date Time Fixtures #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drish-xD
force-pushed
the
feature/date-picker
branch
from
321595a
to
562ae70
Compare
Drish-xD
force-pushed
the
feature/date-picker
branch
from
562ae70
to
b3d6eb6
Compare
suryabulusu
reviewed
Aug 20, 2024
| @@ -93,7 +93,7 @@ const TimePickerInput = React.forwardRef<HTMLInputElement, TimePickerInputProps> | |||
| setDate(setDateByType(tempDate, newValue, picker, period)); | |||
| } | |||
| if (e.key >= '0' && e.key <= '9') { | |||
| if (picker === '12hours') setPrevIntKey(e.key); | |||
| if (picker === 'hours') setPrevIntKey(e.key); | |||
There was a problem hiding this comment.
what are possible values of picker other than hours
There was a problem hiding this comment.
Previously there are 2 options like 12hours format or 24hours format.
I removed 24hours related code as it was redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preview
Preview