-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing API to append Data #16
Conversation
<table style={{ width: "100%" }}> | ||
<tbody> | ||
<tr> | ||
<td>Test_type: {type}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a configurable list via a separate json file. you can loop over them. keep a note of this and make an issue.
json file will have key_name and key pair.
{"Test Takers Count": "testTakers", "Test Format": "format"}
and you can write a loop here -- that iterates over this json file. it displays the key_name
in header, and db_row[key] as column value.
Current code is not easily configurable. With this json file, we just have to make a change in json and it will handle everything. Also, current code is repetitive wherein each column/row can be easily iterated over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Fixes #17
ADR : https://www.notion.so/avantifellows/ADR-Appending-Data-9ca0b4f09f47413e8e5df1844c7a4029?pvs=4
Summary
Test Plan
NEXT_PUBLIC_BACKEND_URL
Represents the URL at which the DB is present currently using local db.json for storing and fetching the SessionDetails which will be replaced by PostgresDBLocal Language Supportdocs/ENV.md
,.env.example
and the Github workflows.alt
attributes<img>
tags havewidth
andheight
specifiedtarget="_blank"
links haverel="noopener"
aria-label
attributes set