-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data display from the forms #14
Conversation
import { Step } from "@/pages/SessionCreator"; | ||
import React from "react"; | ||
|
||
//Navigates throught different sub-pages by passing the current step and the active step and renders the components based on the sub-page user is presented at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove the comment -- have it no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
src/components/Steps/TestDetails.tsx
Outdated
/> | ||
<input | ||
required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why set it as required
-- the idea was to remove them from form na
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes , removed them but should we have a auth layer so that it is only available to a certain set of users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya i think there'll be an auth layer for quiz-creator "writing" part. but reading part is open to all.. at least in AF.
thing is -- links get generated after a while (atleast a minute if automated, or more than few hours if manual run to generate links). so, session_id and quiz_id etc will remain empty for a while
src/pages/SessionCreator.tsx
Outdated
test: {}, | ||
timeline: {}, | ||
}); | ||
console.log(data!); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
}); | ||
console.log(data!); | ||
|
||
const createSession = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally for now this should add to a database.json
sort-of file that mimicks a db
@@ -0,0 +1,38 @@ | |||
import { RowType } from "@/types/types"; | |||
|
|||
export const data: RowType[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add one more row to see how multiple rows appear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have done that , should I do it again and take a screenshot of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no its fine -- once u commit i can check on staging link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Fixes #13
Summary
This PR aims to store the information added by the user when creating a session i.e from the StudentDetails , TestDetails and Timeline
Test Plan
Local Language Supportdocs/ENV.md
,.env.example
and the Github workflows.alt
attributes<img>
tags havewidth
andheight
specifiedtarget="_blank"
links haverel="noopener"
aria-label
attributes set