Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data display from the forms #14

Merged
merged 8 commits into from
Aug 25, 2023
Merged

Data display from the forms #14

merged 8 commits into from
Aug 25, 2023

Conversation

Prakhar-commits
Copy link
Contributor

@Prakhar-commits Prakhar-commits commented Aug 16, 2023

Fixes #13

Summary

This PR aims to store the information added by the user when creating a session i.e from the StudentDetails , TestDetails and Timeline

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable, update docs/ENV.md, .env.example and the Github workflows.
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVG buttons without text have their aria-label attributes set

import { Step } from "@/pages/SessionCreator";
import React from "react";

//Navigates throught different sub-pages by passing the current step and the active step and renders the components based on the sub-page user is presented at
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove the comment -- have it no

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

/>
<input
required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why set it as required -- the idea was to remove them from form na

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes , removed them but should we have a auth layer so that it is only available to a certain set of users?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya i think there'll be an auth layer for quiz-creator "writing" part. but reading part is open to all.. at least in AF.
thing is -- links get generated after a while (atleast a minute if automated, or more than few hours if manual run to generate links). so, session_id and quiz_id etc will remain empty for a while

test: {},
timeline: {},
});
console.log(data!);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

});
console.log(data!);

const createSession = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally for now this should add to a database.json sort-of file that mimicks a db

@@ -0,0 +1,38 @@
import { RowType } from "@/types/types";

export const data: RowType[] = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add one more row to see how multiple rows appear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have done that , should I do it again and take a screenshot of it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no its fine -- once u commit i can check on staging link

Copy link
Contributor

@suryabulusu suryabulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments

Copy link
Contributor

@suryabulusu suryabulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Prakhar-commits Prakhar-commits merged commit 87b91c6 into main Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store and Display User Data
2 participants