Golang test cases for main.go, env.go; Playwright test cases for home page, chapter list & add chapter screens #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ankurcdoshi
commented
Nov 11, 2024
•
ankurcdoshi
commented
- Code refactoring required to make code testable
- Test cases for env.go & main.go files
- Playwright tests on home page load and tabs, dropdown selection change, chapter list screen, columns' sort state, add chapter screen, delete chapter
1. Code refactoring required to make code testable 2. Test cases for env.go & main.go files
Playwright tests on dropdown selection change, chapter list screen, columns' sort state, add chapter screen
ankurcdoshi
requested review from
pritamps,
deepansh96,
suryabulusu and
Bahugunajii
Sort icon related test case was failing when run together with all other tests, although it was working fine individually. Fixed by correcting sort state related code - Update sort state only if url has sort related query parameter, not otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.