-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Validator manager audit #640
Conversation
@@ -1,8 +0,0 @@ | |||
# Audits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we no longer want to have a README that points to the audits (updated of course)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would probably be a good idea... I'm just trying to think of the best way to do it. Should we only include line items for the most recent audit for any given contract? For instance, it doesn't feel helpful to list the Least Authority teleporter
audit from July 2023, since this is not we want anyone to deploy. But even the most recent audit for teleporter
isn't done on the exact commit that we tagged v1.0.0
. I'm having trouble figuring out the best way to communicate best practices here 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to keep a historical accounting of all the audits. Perhaps it can be broken down into two sections: Latest audit, and historical audits with text to make it clear that the old contracts should not be deployed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep all audit reports in the repository, pointing readers to the relevant, most up-to-date audits. Advise that old audits may now be obsolete, and legacy code superseded by new versions are not recommended for production deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that rendered markdown links correctly to the audits!
Why this should be merged
Adds Validator Manager audit.
Moves ICTT audit into root audit folder.
How this works
How this was tested
How is this documented