Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting P-Chain blockchain id constant #562

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Setting P-Chain blockchain id constant #562

merged 5 commits into from
Sep 19, 2024

Conversation

minghinmatthewlam
Copy link

Why this should be merged

P-Chain blockchain id is bytes32(0) for all Avalanche networks, no need to pass in as a parameter

How this works

adds a constant, and removes the parameter

How this was tested

CI

How is this documented

comment

@minghinmatthewlam minghinmatthewlam requested a review from a team as a code owner September 19, 2024 15:43
@minghinmatthewlam minghinmatthewlam changed the base branch from main to staking-contract September 19, 2024 15:43
geoff-vball
geoff-vball approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

felipemadero
felipemadero reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@felipemadero felipemadero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have some issues in tests/utils/staking.go

@minghinmatthewlam minghinmatthewlam merged commit ef2425c into staking-contract Sep 19, 2024
12 checks passed
@minghinmatthewlam minghinmatthewlam deleted the p-chain-id branch September 19, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoff-vball geoff-vball geoff-vball approved these changes

@iansuvak iansuvak Awaiting requested review from iansuvak iansuvak was automatically assigned from ava-labs/interop

@bernard-avalabs bernard-avalabs Awaiting requested review from bernard-avalabs bernard-avalabs was automatically assigned from ava-labs/interop

@michaelkaplan13 michaelkaplan13 Awaiting requested review from michaelkaplan13 michaelkaplan13 was automatically assigned from ava-labs/interop

@cam-schultz cam-schultz Awaiting requested review from cam-schultz cam-schultz was automatically assigned from ava-labs/interop

@felipemadero felipemadero Awaiting requested review from felipemadero

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minghinmatthewlam @geoff-vball @felipemadero