Update subnet-evm/avalanchego and remove hardcoded timeouts from tmpnet #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
feuGeneA,
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
geoff-vball
approved these changes
Sep 6, 2024
feuGeneA
approved these changes
Sep 6, 2024
| @@ -128,9 +126,9 @@ func NewLocalNetwork( | |||
| avalancheGoBuildPath, ok := os.LookupEnv("AVALANCHEGO_BUILD_PATH") | |||
| Expect(ok).Should(Equal(true)) | |||
|
|
|||
| ctxWithTimeout, cancelBootstrap := context.WithTimeout(ctx, timeout) | |||
| ctx, cancelBootstrap := context.WithCancel(ctx) | |||
There was a problem hiding this comment.
Not related to your change here (and I probably wrote this code myself 😅 ) but shouldn't the defer come before the context is passed into BootstrapNewNetwork?
There was a problem hiding this comment.
Indeed -- thanks for noticing
geoff-vball
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Latest changes make tmpnet a bit slower to startup. To update to the newest versions and have the E2E tests pass we need to extend timeouts. Since this repo is used downstream in the
awm-relayerrepo as well I madeNewLocalNetworkaccept a context and let the caller handle setting timeouts.How this works
How this was tested
CI
How is this documented
N/A