-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts top level #422
Merged
+70
−73
Merged
Contracts top level #422
Changes from 17 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ab29ee4
libs to top level
cam-schultz ba00a78
remove old libs
cam-schultz 8612bb8
subnet-evm v0.6.2
cam-schultz 5591ed8
update remappings
cam-schultz 27feb51
top level foundry project
cam-schultz a1c1330
update forget-std ver
cam-schultz 821c980
remove contracts/src
cam-schultz 6a22956
update bindings
cam-schultz ca9155a
update paths in jobs
cam-schultz a6a4da9
format
cam-schultz ddcf620
update path
cam-schultz deb2569
subnet-evm v0.6.1
cam-schultz bdd9297
forge-std v1
cam-schultz 4bc2441
bump foundry version
cam-schultz 78212b2
bump foundry ver
cam-schultz 2273773
format
cam-schultz 6000426
update bindings
cam-schultz d6fd2cc
ignore test compiler warnings
cam-schultz 16fb775
fix compiler warnings
cam-schultz 5c88d99
lowercase dirs
cam-schultz 1488a35
governance and utilities dirs
cam-schultz 7b48f10
Merge branch 'main' into contracts-top-level
cam-schultz 81ebe2c
complete merge
cam-schultz fc4120c
Partial Merge branch 'main' into contracts-top-level
cam-schultz 93fe8b5
finish merge
cam-schultz 56c416e
Merge branch 'main' into contracts-top-level
cam-schultz fd5b9f6
remove ignore=dirty
cam-schultz fb216a7
update docs path
cam-schultz fae3473
disable auto remapping
cam-schultz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,14 @@ | ||
[submodule "contracts/lib/forge-std"] | ||
path = contracts/lib/forge-std | ||
url = https://github.com/foundry-rs/forge-std | ||
[submodule "lib/forge-std"] | ||
branch = v1.3.0 | ||
[submodule "contracts/lib/openzeppelin-contracts"] | ||
path = contracts/lib/openzeppelin-contracts | ||
url = https://github.com/openzeppelin/openzeppelin-contracts | ||
branch = v1 | ||
path = lib/forge-std | ||
url = https://github.com/foundry-rs/forge-std | ||
ignore = dirty | ||
[submodule "lib/openzeppelin-contracts"] | ||
branch = v4.8.1 | ||
[submodule "contracts/lib/subnet-evm"] | ||
path = contracts/lib/subnet-evm | ||
path = lib/openzeppelin-contracts | ||
url = https://github.com/openzeppelin/openzeppelin-contracts | ||
ignore = dirty | ||
[submodule "lib/subnet-evm"] | ||
branch = v0.6.1 | ||
path = lib/subnet-evm | ||
url = https://github.com/ava-labs/subnet-evm |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
lib/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
## ABI Bindings | ||
|
||
This directory contains ABI bindings for the Solidity contracts in the `contracts/src/CrossChainApplications` and `contracts/src/Teleporter` directories. The files with the same name as the Solidity source files are automatically generated by the `scripts/abi_bindings.sh` script. Other files in this directory (such as the packing utilities) are manually created and maintained. | ||
This directory contains Solidity contract ABI bindings. The files with the same name as the Solidity source files are automatically generated by the `scripts/abi_bindings.sh` script. Other files in this directory (such as the packing utilities) are manually created and maintained. |
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to change the
lib/forge-std
branch and/or add theignore = dirty
flags here? Seems like just changing the paths would be sufficient.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When putting together this change, I noticed a few things:
From what I could tell, this means that the exact forge-std version that's used is whatever one is found first when resolving include paths. To get around this, I added forge-std to remappings.txt explicitly, and updated our submodule to use the same version as openzeppelin-contracts
As for
ignore = dirty
, that is added as a developer convenience. I noticed that when playing with submodules it was quite easy to get to a state in which no submodule changes were made, but it was still showing as modified ingit status
.ignore = dirty
shouldn't impact CI or fresh clones.